3 ms·

Amazing given ffi-napi is broken for several years already https://github.com/node-ffi-napi/ref-napi/issues/54 https://github.com/node-ffi-napi/ref-napi/issues

by nshm 4y ago

Amazing given ffi-napi is broken for several years already https://github.com/node-ffi-napi/ref-napi/issues/54 https://github.com/node-ffi-napi/ref-napi/issues/54

capableweb 4y ago
It seems like people have suggested multiple times to you to open a pull request with your suggested changes, rather than keeping them in your own repository. You asked for a merge in the comments too, but didn't address the concern regarding backwards-compatibility. The ball is in your court Edit: Your changes are also not cleaned up, https://github.com/node-ffi-napi/ref-napi/compare/latest...alphacep:ref-napi:latest#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R53 https://github.com/node-ffi-napi/ref-napi/compare/latest...a... < includes adding a templating engine as well?
- pavelevst 4y ago
  May be oot. As a maintainer I always try to accept help what people suggest, and make it even better. Without asking people to write tests or format code to match my preferences or make it cleaner… I often fix some code in my fork, open a pr, but author asking for tests or change something but I simply have no time for it, and for author it will be much easier because he/she is familiar with code style, testing framework, etc. And problem remain unfixed in main repo
  - capableweb 4y ago
    Sure, if neither you or the maintainer has the time nor will to actually make the change mergable, then it probably won't get fixed. But when this happen, do you do the same thing nshm does and writes about how the whole project is broken and they won't merge your uncompleted code?
    - pavelevst 4y ago
      If project is really broken then I would agree with it
      - capableweb 4y ago
        Sure, but given that ref-napi gets about 227K downloads each month, I find it very unlikely that the project as a whole is broken. It might be broken for parent commentator that goes around complaining about it, because they encounter that specific bug. But seems not everyone is getting hit by it, then someone would at least contribute a fix to it, which no one has done yet.

by nshm 4y ago

Amazing given ffi-napi is broken for several years already https://github.com/node-ffi-napi/ref-napi/issues/54 https://github.com/node-ffi-napi/ref-napi/issues/54

capableweb 4y ago

It seems like people have suggested multiple times to you to open a pull request with your suggested changes, rather than keeping them in your own repository. You asked for a merge in the comments too, but didn't address the concern regarding backwards-compatibility. The ball is in your court Edit: Your changes are also not cleaned up, https://github.com/node-ffi-napi/ref-napi/compare/latest...alphacep:ref-napi:latest#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R53 https://github.com/node-ffi-napi/ref-napi/compare/latest...a... < includes adding a templating engine as well?

pavelevst 4y ago
May be oot. As a maintainer I always try to accept help what people suggest, and make it even better. Without asking people to write tests or format code to match my preferences or make it cleaner… I often fix some code in my fork, open a pr, but author asking for tests or change something but I simply have no time for it, and for author it will be much easier because he/she is familiar with code style, testing framework, etc. And problem remain unfixed in main repo
- capableweb 4y ago
  Sure, if neither you or the maintainer has the time nor will to actually make the change mergable, then it probably won't get fixed. But when this happen, do you do the same thing nshm does and writes about how the whole project is broken and they won't merge your uncompleted code?
  - pavelevst 4y ago
    If project is really broken then I would agree with it
    - capableweb 4y ago
      Sure, but given that ref-napi gets about 227K downloads each month, I find it very unlikely that the project as a whole is broken. It might be broken for parent commentator that goes around complaining about it, because they encounter that specific bug. But seems not everyone is getting hit by it, then someone would at least contribute a fix to it, which no one has done yet.