3 ms·
Someone brought it up in a retro. We then kept the shorter ones under 24 hours, though a huge one may still take a few days. I think you just have to set it up
by muzani 4y ago
Someone brought it up in a retro. We then kept the shorter ones under 24 hours, though a huge one may still take a few days. I think you just have to set it up as a policy with colleagues, and most would agree that it's reasonable.
The back and forth is part of the process, but it's a lot shorter once someone has actually read the code.
Also lowering the bar helps. We do review badly formatted stuff and misleading variable names. And definitely check for major bugs. But not poorly named variables and inconsistent architecture, unless it conflicts with a written code style doc.
Part of the delay is thinking of a way to "negotiate" a style change. I'd recommend putting a written style guide to minimize that. If you want it to be camel case or whatever, negotiate it on the style guide.