3 ms·
> "I reviewed a bunch of PRs yesterday" sounds bad in standup The real problem is here. Code review must be a first class citizen of your team culture to be su
by bil7 4y ago
> "I reviewed a bunch of PRs yesterday" sounds bad in standup
The real problem is here. Code review must be a first class citizen of your team culture to be successful. It is the responsibility of management/scrum master/etc to foster and if necessary enforce the culture
- worker_person 4y agoUsually comes down to one of * I don't see any divide by zero bugs. Approved. * Some inane argument about code style that the linter enforces. * I spent 8 hours figuring out what you did, why you did it, reviewing how code matches the requirements, running the code, testing all the scenarios. * Can we rewrite this entire thing because I prefer a different pattern?
- bil7 4y agohaha, I've definitely seen some of those. Comment standards are worth obeying, personally I like the code review pyramid https://www.morling.dev/blog/the-code-review-pyramid/ https://www.morling.dev/blog/the-code-review-pyramid/
- akhmatova 4y agoCode review must be a first class citizen of your team culture to be successful. Yup, you nailed it. Overall it sounds like the culprit here is inexperienced management -- that somehow "knows" that code review is important, but doesn't (really) understand why. To the extent of being able to justify the, you know, time cost involved to upper management constantly breathing down their necks to get the next shiny new button working.