4 ms·
Code reviews can bottleneck development, so I was thinking it'd be nice if I could just commit at end of day... Then in the morning, I'd come in to an email box
by cperciva 18y ago
Code reviews can bottleneck development, so I was thinking it'd be nice if I could just commit at end of day... Then in the morning, I'd come in to an email box magically full of corrections, criticisms, etc.
This sounds like open source development. There's a reason why people joke that the fastest way to get a patch reviewed is to commit it. :-)
But more seriously: Finding people who are good at reviewing your code is very difficult. The more obscure the code you're writing -- that is, the more you actually need your code to be reviewed -- the fewer the number of people who would be competent to review it; so any attempt to put together a generic "group of reviewers" isn't likely to get the most important code reviewed.
If I were you, I'd think about what specific things you're doing in which you're likely to make mistakes -- generally speaking, this means sorts of code which you don't have much experience writing -- and then go out and look for experts to review for those specific bits of code.
I'm available for contract work reviewing cryptographic code. :-)
- ggruschow 18y agoFinding people who are good at reviewing your code is very difficult. I think this is generally true even without the emphasis on my particular code. Most folks suck even more at reviewing than they do at coding. And of course it's always hard to find really good developers. I think there might be attractive qualities for a high quality developer to take on such a project though.. For instance: Short off-time hours.. like someone in Seattle could review pretty interesting code after their stupid day of meetings that they got sucked into by being too good at their job. Hell, they might be able to do it _in_ the meetings. Pay... I'd happily pay well over good dev rates for a good reviewer (or set of reviewers). People telling me how I'm dumb and how to improve is great. Joy of working outside of Java / C# / C++ / VB / ASP.NET corporate code. Freedom to rip stuff apart without fearing for one's job or worrying about office politics. Some of us have a lot of pent up rage :)
- ggruschow 18y agoThe more obscure the code you're writing -- that is, the more you actually need your code to be reviewed The only part that should be obscure is why the program is even useful and why it has some features at all. The code and design should be entirely understandable given a 1-page overview document. I'm certainly not talking about cryptographic code as you mentioned. I'd actually guess that's the case for most code written in the world. Given certain business needs, the code should be reasonably understandable for someone who wants to understand.