3 ms·
Exactly this. I fixed a problem like this a week ago. I found some duplicated code, factored it out into one place by introducing an abstract base class (Python
by eloff 4y ago
Exactly this. I fixed a problem like this a week ago. I found some duplicated code, factored it out into one place by introducing an abstract base class (Python) and in the process discovered one of the duplicated methods had a logic error leading to returning a slightly smaller integer result.
The code had test coverage, but the test confirmed that it produced the wrong result. I had to fix the test too.
- TwoHeadedBeast 4y agoSo your refactor broke the tests, so you assumed the tests must be wrong.
- 83457 4y agoSo his refactor fixed a bug and broke a test which he fixed, so you assume he must have assumed instead of verified.