3 ms·
Yours is nice and readable. Parents' one is not, but it feels like the indentation is deliberately confusing. I'd lay it out like so: tags = list(set([
by int_19h 4y ago
Yours is nice and readable. Parents' one is not, but it feels like the indentation is deliberately confusing. I'd lay it out like so:
tags = list(set([
nel
for subli in [
mel
for subl in [
[[jel.split('/')[2:] for jel in el]
for el in classified
]
for mel in subl
]
for nel in subli
if nel
]))
Still not very readable, tho. But that's largely due to Python's outputs-first sequence comprehension syntax being a mess that doesn't scale at all.
Side note: one other thing I always hated about those things in Python is that there's no way to bind an intermediary computation to a variable. In C# LINQ, you can do things like:
from x in xs
let y = x.ComputeSomething()
where y.IsFoo && y.IsBar
select y
In Python, you have to either invoke ComputeSomething twice, or hack "for" to work like "let" by wrapping the bound value in a container:
y
for x in xs
for y in [x.ComputeSomething()]
if y.IsFoo and y.IsBar
It's not just about not repeating yourself or not running the same code twice, either - named variables are themselves a form of self-documenting code, and a sequence pipeline using them even where they aren't strictly needed can be much more readable.
- texaslonghorn5 4y agoDoes the new walrus := in python solve your problem?
- roelschroeven 4y agoThe official name is assignment expression, which can be good to know to find documentation. Here's the PEP: https://peps.python.org/pep-0572/ https://peps.python.org/pep-0572/
- otherme123 4y agoCuriously, searching the docs for "walrus" (https://docs.python.org/3/search.html?q=walrus https://docs.python.org/3/search.html?q=walrus) yields exactly the results you need, but searching for "assignment expression" yields the previous results mixed a lot of other results due to the word "expression".
- int_19h 4y agoNot really; where would you put it inside the []?
- dragonwriter 4y agoIn the example from the end of the earlier post: y for x in xs if (y:=x.ComputeSomething()).IsFoo and y.IsBar
- int_19h 4y agoI suppose that works, although readability is not great, to put it mildly.
- texaslonghorn5 4y agoMuch better would be [(y:=x.ComputeSomething()) for x in xs if y.IsFoo and y.IsBar]
- int_19h 4y agoThat doesn't work, because that first subexpression is evaluated last, after "if".
- ChadNauseam 4y agoFor another example of how to use the walrus operator, I use it multiple times in the code I linked a few comments up
- dragonwriter 4y ago> But that's largely due to Python's outputs-first sequence comprehension syntax being a mess that doesn't scale at all. Choices like wrapping a set constructor around a list comprehension rather than just using a set comprehension don't help, neither does using multiple nested no-transformation comprehensions laid out that way. By hand, on mobile, I think this reduces to (assuming “from itertools import chain” in the file header): tags = list({ nel for subli in chain.from_iterables(chain( [[jel.split('/')[2:] for jel in el] for el in classified)) for nel in subli if nel })
- andrewaylett 4y agoSince it's all generator expressions internally anyway, an intermediate doesn't actually add appreciable (any?) runtime overhead but does make the code more readable: ys = (x.ComputeSomething() for x in xs) result = [y for y in ys if y.isFoo and y.isBar]