5 ms·
I checked and you're right: The endpoint that returns the file list has a hardcoded set of excludes and pays no attention to `.gitattributes`. I think it's rea
by brasic 4y ago
I checked and you're right: The endpoint that returns the file list has a hardcoded set of excludes and pays no attention to `.gitattributes`.
I think it's reasonable to respect the linguist overrides here so I'll open a PR to remove entries from the exclude if the repo has a `-linguist-generated` or `-linguist-vendored` gitattribute for that directory [1]. So in your case you can add
build/** -linguist-generated
to `.gitattributes` and once my PR lands files under `build` should be findable in file-finder.
Thanks for pointing this out! Feel free to DM me on twitter (@cbrasic) if you have more questions.
[1] Recursively matching a directory with gitattributes requires the `/**` syntax unlike .gitignore: https://git-scm.com/docs/gitattributes#:~:text=with%20a%20few%20exceptions https://git-scm.com/docs/gitattributes#:~:text=with%20a%20fe...
- jakub_g 4y agoAwesome! Thanks!
- hoten 4y agoAmazing, thanks!
- brasic 4y agoFor anyone watching this thread, shoot me a DM if you’d like to test this change. It should be enabled in all repos within a week or two.
- brasic 4y agoThis is shipped for github.com! See https://github.com/github/docs/commit/37df8eadb1f3bd0c2606537d61a87c6ad0acdb74 https://github.com/github/docs/commit/37df8eadb1f3bd0c260653... which is now live on https://docs.github.com/en/search-github/searching-on-github/finding-files-on-github https://docs.github.com/en/search-github/searching-on-github...