3 ms·
You must not ever work with junior developers. Rarely do I see a properly created commit history, what you usually get is something like: add upd fix u
by 5e92cb50239222b 4y ago
You must not ever work with junior developers. Rarely do I see a properly created commit history, what you usually get is something like:
add
upd
fix
upd
fix
Rebasing that stuff before merging it into master feels mandatory, or you're left with history with a very low signal-to-noise ratio.
- CuriousCosmic 4y agoThat or you are stuck with somebody fighting CI or issues that aren't reproducible in their environment. It's not necessarily a junior dev issue and can just be "our tooling sucks and management refuses to invest time or money into fixing it". It's not an ideal or sustainable work environment but it's something that even senior devs still have to deal with. Of course that should still be rebased down to a reasonable history.
- dreamcompiler 4y agoThe solution for this is not rewriting history but writing a smarter history viewing tool that filters out the noise.
- menaerus 4y ago> what you usually get is something like: That's like 9 out of 10 people in my experience and none of them are juniors. It's pretty hard to get developers more disciplined.
- dotancohen 4y agoIf that's the case, I would have the dev go rebase that into a nice single commit. Not the guy doing the integration work. I expect that the dev's last operation was to merge from the dev branch, fix conflicts, then push a PR. At the least, if you're dev refuses to give you a nice commit, you could merge-squash his branch.