5 ms·
Multicorn developer here, I'll be glad to answer any question.
by rdunklau 15y ago
Multicorn developer here, I'll be glad to answer any question.
- danmaz74 15y agoThis looks interesting, thanks for sharing. But what kind of performance is it possible to get with complex queries on these external sources? Does the PG server need to load all the data in memory from the source to do filters, joins and sorts?
- rdunklau 15y agoThank you for your interest! The postgresql plan is parsed, and passed as a list of "quals", objects representing simple filters. As an implementer, you don't HAVE to enforce those, since postgresql will recheck them for you anyway, but they can be quite handy. For example, you can look at the imap foreign data wrapper (https://github.com/Kozea/Multicorn/blob/master/python/multicorn/imapfdw.py https://github.com/Kozea/Multicorn/blob/master/python/multic...) to see how the conditions from postgresql are converted to an IMAP filter, allowing for server side filtering. The required columns are also provided, so if you don't need the email payload, the foreign data wrapper will not fetch it. For joins, it will depend on the execution plan. There is still plenty of work on parsing the postgresql execution plan into something more useful, but the current set of "optimizations" is sufficient for our main use cases.
- danmaz74 15y agoThank you for the explanation. I don't have an immediate need for this, but it's an interesting approach. Good luck!
- wulczer 15y agoCrap, I'm working on something exactly like this :D Was about to upload it to Github just today, but still wanted to fix a few things. Yours looks quite more finished, one thing that would be very useful is handling Python to Postgres type conversion, like PL/Python does. After that, the next step is caching I/O functions for the duration of the scan, which PL/Python also does. Nice to see that the idea made sense for more than one person, hope Multicorn will rock!
- rdunklau 15y agoSorry to beat you at it ;) We currently have some very rudimentary python to postgres type conversion, but this area still need a lot of improvements. You should release your code, I'm sure you have a wide range of ideas worth merging into Multicorn !
- wulczer 15y agoActually, the ideal thing to happen would be for PL/Python to somehow become a shared library that provides the typecasting routines, but I'm afraid that's a very big task and difficult to get accepted upstream. It's sad that PL/Python already includes all the code you need to transform Python lists to Postgres arrays, bools to PG bools and so on and every project like this one has to duplicate all that logic. BTW: in my approach I opted for passing the entire Qual node as a string (using nodeToString) and my plan was to write a Python parser for that format that takes a string and returns a Python object. Not sure how hard that will turn out.
- rdunklau 15y agoI totally agree with you regarding PL/Python. I may try to ask upstream what they think about it.