3 ms·
There is a graph of your submitted commits/LoC/code review comments over time, overlayed with the rest of your teams metrics. Managers will tell you that those
by plantwallshoe 4y ago
There is a graph of your submitted commits/LoC/code review comments over time, overlayed with the rest of your teams metrics.
Managers will tell you that those metrics are not important to your performance review , but it is absolutely not true. They didn’t make the graph so it can be ignored.
- pbalau 4y agoBefore I've left fb, early 2018, loc/code review did not matter. Around 2016, there was a push to switch to management from within the engs. This did not go that well. After, since the company kept growing and there was a real need to get more managers, they started hiring from outside. One of these outside hires become my manager and he was the reason I left. Code review used to be on the same axis as onboarding, office hours, that sort of thing.