3 ms·
What's annoying about this is that the PR doesn't even say it's trying to run tests. It says everything is passing and just doesn't list the actions. For a sec
by eatonphil 4y ago
What's annoying about this is that the PR doesn't even say it's trying to run tests. It says everything is passing and just doesn't list the actions.
For a second I thought someone must have deleted the actions yaml files.
This is a dangerous failure mode.
https://github.com/multiprocessio/dsq/pull/82 https://github.com/multiprocessio/dsq/pull/82
Screenshot here: https://twitter.com/phil_eaton/status/1542168020516216832 https://twitter.com/phil_eaton/status/1542168020516216832
- OJFord 4y agoAs in you have it configured to prevent merge until they passed, they're not running at all, and it's allowing merges?
- eatonphil 4y agoThat's right. This button shouldn't be green. But it's not just that the actions aren't running but their service that reports that actions exist must be down too. That is a bad design. They should still report that the actions exist even if they can't run them. This PR button shouldn't be green/pressable.
- JelteF 4y agoThere's a way around this: Under "branch protection rules" in the settings for the repo, you can require certain "status checks" to be green before merging. This has as an added benefit that it works for allowing "auto-merge" (at the settings page of the repo). (I work at Microsoft, but not at Github)
- eatonphil 4y agoYes that is set already and that's why this is so concerning.
- NoNameProvided 4y agoYou can set Actions to required and then they will be displayed even when Actions is down and merge will be prevented.