3 ms·
I'm fine with all of these. I think the way you phrase it could communicate how confident you are that this should be extracted to a separate function. But I s
by mcv 4y ago
I'm fine with all of these. I think the way you phrase it could communicate how confident you are that this should be extracted to a separate function.
But I see code review as a conversation. Quite often it calls for a bit more discussion, and, depending on how the team deals with this, I sometimes reach out to the developer whose code I reviewed over a separate channel to discuss the issue a bit more.