4 ms·
I tend to be overly “nice” in code reviews and phrase things more like suggestions and provide some justification for them: > have you considered x? It is stan
by glerk 4y ago
I tend to be overly “nice” in code reviews and phrase things more like suggestions and provide some justification for them:
> have you considered x? It is standard practice in y to do z.
> should we do x instead? I think it would be better in the long run because y.
If there is a more serious issue, I prefer DMing the author and hashing things out synchronously.
I think it is important to phrase things gently as much as possible, as tone is hard to read from text, and being overly harsh might discourage other teammates from taking risks and asking for feedback.