4 ms·
Where possible it can also be useful to point out if there are existing guidelines/checklists the submitter should be referencing to understand these preference
by somethoughts 4y ago
Where possible it can also be useful to point out if there are existing guidelines/checklists the submitter should be referencing to understand these preferences of the project. The more the contributors can code review themselves prior to submitting a PR the better.
And if such a resource doesn't exist or that topic is not in the current guidelines/checklists - offering to take up the task of creating or adding an topic to the list of things to check before submitting a PR can be helpful.
Eliminating nitpicky PR comments by having pretty verbose coding guidelines as well as pretty strict settings for automatic code linters/syntax checkers/static type validators means the PR feedback cycle is a lot more focused.
And for architectural discussion - draft PRs can be useful early on for feedback on design choices for more challenging features can be helpful.
- drewcoo 4y agoThis! Walking on eggshells because every comment chain devolves into religious battles about style? Find a linter or style checker that can automate comments/fixes. Talk about those checks in your team meeting, get consensus (who cares what it is, just consensus), and make the tools enforce it. Or suggest your manager do this. If discussing actual code problems in code reviews rankles people, just escalate to your manager. If you need a special code review human language lexicon because people can faint or throw punches, it's a management problem. Because that's the kind of thing that makes other people, not the troublemakers, leave the company.
- dhzhzjsbevs 4y agoI ignore style check nitpick comments. Fix your linter and autoformatter. You don't pay me to lint code.