2 ms·
For code reviews we try to automate as much of the nit-picky things as possible. So for example in our Python code we run checks using: black, isort, flake8, my
by graton 4y ago
For code reviews we try to automate as much of the nit-picky things as possible. So for example in our Python code we run checks using: black, isort, flake8, mypy, and pylint.
For reviewing. I try not to use the word "you" as I feel it can make people feel defensive. So for your options above I would like:
Should this be extracted into a separate function?
As a code reviewer I may think it is obvious that it should be in a separate function or something else that seems obvious. But often times the author has already tried that and had issues with doing that. Thus they did it the way it is because of that.