3 ms·
As someone on the junior end, the tone is less relevant here than the content, and there is not a lot of content. Why do you want it extracted? Will we re-use
by MattGaiser 4y ago
As someone on the junior end, the tone is less relevant here than the content, and there is not a lot of content. Why do you want it extracted?
Will we re-use it? Do you just not like blocks of code bigger than X (been given this reason many times)? Do you just feel the need to comment (a lot of devs do and I appreciate it when they are upfront about that rationale and I have done this myself to show that I am paying attention)? Are you concerned about readability?
I need to know for future code reviews, so I can avoid the issue in the future.
- oldjavacoder 4y agoI like SonarQube for removing ambiguity. If SonarQube is set to fail the build at lower than a certain percentage of coverage or too low of a grade in Maintenance then it gets fixed before the PR even gets filed. Assuming the code is processed by SonarQube for regular branch builds, which it should be.