4 ms·
+1 the reasoning is the entire point and all of these examples are good. Just telling people to make changes without telling why doesn't teach them anything -
by gonehome 4y ago
+1 the reasoning is the entire point and all of these examples are good.
Just telling people to make changes without telling why doesn't teach them anything - especially when sometimes what's being requested isn't actually better (or is at least subjective).
- convolvatron 4y agomy rule is to weigh whether or not its worth making a comment very carefully. nothing without a clear justification. never say 'I would have done it this other way' - unless its a good friend who you often discuss style issues with. comment on things that you feel would make a substantial difference on schedule, maintainability, or function - and provide a clear reasoning with which to argue against. wasting your peers time trying to enforce your style isn't just non-productive, it sours everyone on the whole exercise.