2 ms·
Depending on the situation, one of the following three: > Should we extract this to a separate function? When you are not familiar with the codebase, potentia
by koolba 4y ago
Depending on the situation, one of the following three:
> Should we extract this to a separate function?
When you are not familiar with the codebase, potential reuse, and want the submitter to clarify rationale for the approach.
> This should be extracted to a separate function.
When you are the authority but you're open to a discussion. You should include the "why" aspect in this situation.
> Extract this to a separate function.
When you are the authority and there will be no discussion. If you want you can include the "why" but it's a waste of time. You are the law.
The rest are sugar coated versions of the same thing.
"I think...", "I would...", "Maybe we...", are unnecessary additions. Clearly it's what you would do as you're the one giving the review.
If people are too thin-skinned to take direct feedback then they should work on improving that before submitting more code. Life is too short to waste time picking words that try not offend when you can spend that time actually producing something of value.