2 ms·
My usual approach is to point out the problem I'm trying to solve rather than suggest a specific solution. I also like to phrase as a question about practicali
by amalcon 4y ago
My usual approach is to point out the problem I'm trying to solve rather than suggest a specific solution. I also like to phrase as a question about practicality. Sometimes the answer to that question is "No", and I want to make sure that even someone very junior is comfortable giving me that answer.
- This code looks pretty similar to this other code; is there a way it can be deduplicated?
- I don't understand this code; I think it's because there are too many conceptual steps. Is there some way to structure it for better readability?
- Is there a way to unit test this specific behavior?
Sometimes this style doesn't work (e.g. correcting a comment that has become incorrect due to the change), and in those cases I usually just say "Please do this." I also try to point out things I like when they are present.