2 ms·
I second guess myself and edit a lot, especially relative to how much we actually do code review, so I'm interested to see others' thoughts. I would say though
by OJFord 4y ago
I second guess myself and edit a lot, especially relative to how much we actually do code review, so I'm interested to see others' thoughts.
I would say though that a lot depends on team dynamic & hierarchy. For example, I have no direct reports, so I'm never going to use the imperative as in 'extract this to a separate function' - taken literally, I don't have the authority to tell anyone to do that.
Most often I think I favour 'I would', and give a reason. I.e. I found this a bit surprising, because I would have done it differently.
Along the same lines I also ask (honest) 'is there a particular reason' or 'why not' type questions. Something else seems most obvious to me, but maybe they thought of (even tried) and dismissed that.