3 ms·
"How would you feel about extracting this into a separate function? It might be better because the logic seems quite self-contained, and we can then apply the e
by lhnz 4y ago
"How would you feel about extracting this into a separate function? It might be better because the logic seems quite self-contained, and we can then apply the extra business logic immediately after this with a few if-elses."
I try to give critiques in this way, as it gives the person that wrote the code ample opportunity to defend their approach, but also gives explanation of why your suggestion might be better.