2 ms·
Default to short, polite statements, but make it clearly suggestive if its optional. e.g. "Extract this to a separate function please" if you aren't asking. "S
by JamesSwift 4y ago
Default to short, polite statements, but make it clearly suggestive if its optional.
e.g. "Extract this to a separate function please" if you aren't asking. "Should this be a separate function" otherwise.
This also assumes that theres a certain protocol to PRs in terms of veto power. I've always followed the rule that the writer must make all requested updates by reviewer unless explicitly challenged. In other words, you can't silently not change something they mentioned, but you can say things like "thats out of scope for this update" or "I think this design is better because XYZ" and the writer is able to mark as resolved at that point.
Sometimes this ends up with a conversation that needs to happen where the reviewer disagrees with the writer, but honestly it rarely does at least on the teams I've been on. It would really have to be a contentious point to escalate to that level rather than just being a difference of opinion.