There are three main categories of code reviews: 1.) Things are mainly bad. 2.) Things are mainly good. 3.) Somewhere in between. Within those, everything I

There are three main categories of code reviews: 1.) Things are mainly bad. 2.) Things are mainly good. 3.) Somewhere in between. Within those, everything I see and flag as worthy of discussion is either: 1.) Something that violates our rules/style. 2.) Something I have a strong opinion on. 3.) Something I don’t understand. Depending on which main category the review falls into, I’ll deal with these differently. If things are mostly bad and I don’t understand something, I’ll ask a lot of questions about readability and naming conventions. If something is mostly good and I don’t understand something, I’ll ask “Hey, can you explain lines 71-104?” In general, I try to keep things friendly and positive because I don’t want people to dread the experience. Life is too short to dread a big part of your job.