2 ms·
If it's negative feedback or something that feels controversial I dont put it on a PR at all. I try to do it in person or (remotely) send a private slack messa
by pydry 4y ago
If it's negative feedback or something that feels controversial I dont put it on a PR at all.
I try to do it in person or (remotely) send a private slack message.
People can be sensitive to negative feedback and one way of ameliorating that is not to give it in a public forum where everybody can see it.
- dyingkneepad 4y agoIf this is on an open source community, it's bad advice IMHO. On open source communities, please make all feedback public. It is really important to make the history of the project public. There are many ways to write the feedback in a not-offensive way, many of the comments in this thread have good suggestions.
- pydry 4y agoI was assuming a normal working environment. OSS is a different kettle of fish. You dont have to worry about bruised egos nearly as much & the value of public feedback is higher.
- mytailorisrich 4y agoCode reviews are primarily a way to detect bugs and to verify compliance with a set of rules. Most comments are therefore expected to be 'negative' in some way.