3 ms·
Consider extracting this to a separate function.
by ilrwbwrkhv 4y ago
Consider extracting this to a separate function.
- kelseyfrog 4y agoAfter reviewing my last few code review comments, this is my most frequent phrasing too. I get that questions are a way to soften the bluntness of a code review comment, but I've been hugged to death by this sort of niceness in the past. It was not fun. "Consider ______" has the directness I, myself, enjoy, and whose response can take the form of a change, a reply, or a jumping off point for discussion. It indicates some action needs to take place without specifying exactly which one and leaves me open to having my mind changed if the response is "I've considered it and actually ..." Still, if there is ever a flaw so great that the code simply will not work without a fix, I will phrase the fix in the form of a command.