3 ms·
A good way to package possibly negative feedback is to formulate it as an I-message, or an observation and go from there: "I find this method to be overwhelmin
by tetha 4y ago
A good way to package possibly negative feedback is to formulate it as an I-message, or an observation and go from there:
"I find this method to be overwhelmingly long and it's hard to keep track through all of it. However, it looks like this, this and this are rather isolated steps, they could be extracted to make the overall structure easier to see".
"To me, this, this and this look like duplicated code. Do you expect them to evolve differently, or could they be extracted into a common function / module?"
And if the code goes against architectural or style guidelines, it also softens the feedback to start with that reason and go to the suggesting from there. "This class was designed to be independent of that module to be testable. Please extract your code into the foobar-interface and inject it"