10 ms·
Interesting! I'm sure you thought of the possibility of having reviewers pull code they are asked to review rather than having it pushed to a non-master branch
by kragen 4y ago
Interesting! I'm sure you thought of the possibility of having reviewers pull code they are asked to review rather than having it pushed to a non-master branch in their repo, which would have avoided the Gitolite headaches; what are the advantages of the push model?
- mike_hearn 4y agoThe push is the "pull request" in this model. It triggers CI, which in turn triggers notifications to the reviewer that there's pending work. The `rr` namespace acts as the inbox for requests. Deleting the `rr` branch is like closing it. There's also clarity over ownership that way - the `rr` branch is owned by the owner of the repository and they can push to it, to make it into whatever form they want. Devs may also explicitly send a message indicating there's work to be reviewed, but they don't have to.