19 ms·

> "You want to know what's better than having actual MS developers interact with your issue on GH? Being able to submit a MR yourself and actually have that MR

> "You want to know what's better than having actual MS developers interact with your issue on GH? Being able to submit a MR yourself and actually have that MR be merged in within days of it being good to go." .NET isn't your average hobby project - it's used everywhere. It's imperative that changes go through the proper due process here. It takes time to prepare design documents and review them, discuss the changes and different alternatives, review the code, implement the changes and test them properly. If that's somehow a problem to you, I think your expectations need to be readjusted. This is not the kind of project that should hastily accept code.

robertlagrant 4y ago
It's not used everywhere, or not to a significant degree different to how Ruby is, which was in the example of the post you were replying to. And this isn't about haste, it's about openness. Code that is well written and passes tests can be reviewed and merged in hours, let alone days, without being considered hastily included.
Etheryte 4y ago
This is an absurd straw-man. Nowhere did the parent comment say anything of the kind you're arguing against. In fact, they highlighted that you should the follow the procedures and rules. This is silly.
- nightski 4y ago
  The parent said within a few days. That might not be realistic with the processes in place and I think that's all they were getting at.
tinco 4y ago
I'd be very surprised if Microsoft's development process is more thorough than that of Rust or even Rails. These are not your average hobby projects, it is imperative that changes go through the proper due process there. It takes time to prepare design documents and review them, discuss the changes and different alternatives, review the code, implement the changes, test them properly, and you can participate in all those steps.
- zamalek 4y ago
  Having submitted a somewhat trivial PR (System.HashCode), they really put you through the ringer. It took almost 3 weeks of constant (and valuable) feedback for the PR to move into a state that they liked. All of this about dotnet not accepting PRs is unadulterated "Micro$uck FUD". The other critiques are valid, but not this one, not by a mile, it is complete bullshit.
renewiltord 4y ago
The guy's got code into Ruby, rustc, and Rails. I'm pretty sure he knows what it takes to get things into master at a widely used project.
- tinco 4y ago
  Just so no one's deterred, it's actually not very difficult to do this. The rustc and ruby patches I submitted as an exercise. I went to the issue tracker, sorted by oldest first, and then picked the first issue that had little/no discussion on it. I purposefully avoided picking an issue with significant architectural impact or political context this way. So there's also not much designing and reviewing needed. The merge requests were assigned to very senior reviewers each time. The automated test suites made sure I didn't waste much of anyone's time with trivial errors. Of course the requirement is that you're actually at least proficient with the languages (C for Ruby and Rust for rustc) but beyond that I think anyone can do it with a couple of sunday afternoons spent diligently digging through the codebase.
SauciestGNU 4y ago
Ruby and Rust and Rails aren't exactly hobby projects either. Mission critical software exists that uses those as well. Ultimately it's on the development and deployment teams to pin a version of the runtime for actual consistency in environment.

robertlagrant 4y ago

It's not used everywhere, or not to a significant degree different to how Ruby is, which was in the example of the post you were replying to. And this isn't about haste, it's about openness. Code that is well written and passes tests can be reviewed and merged in hours, let alone days, without being considered hastily included.

Etheryte 4y ago

This is an absurd straw-man. Nowhere did the parent comment say anything of the kind you're arguing against. In fact, they highlighted that you should the follow the procedures and rules. This is silly.

nightski 4y ago
The parent said within a few days. That might not be realistic with the processes in place and I think that's all they were getting at.

tinco 4y ago

I'd be very surprised if Microsoft's development process is more thorough than that of Rust or even Rails. These are not your average hobby projects, it is imperative that changes go through the proper due process there. It takes time to prepare design documents and review them, discuss the changes and different alternatives, review the code, implement the changes, test them properly, and you can participate in all those steps.

zamalek 4y ago
Having submitted a somewhat trivial PR (System.HashCode), they really put you through the ringer. It took almost 3 weeks of constant (and valuable) feedback for the PR to move into a state that they liked. All of this about dotnet not accepting PRs is unadulterated "Micro$uck FUD". The other critiques are valid, but not this one, not by a mile, it is complete bullshit.

renewiltord 4y ago

The guy's got code into Ruby, rustc, and Rails. I'm pretty sure he knows what it takes to get things into master at a widely used project.

tinco 4y ago
Just so no one's deterred, it's actually not very difficult to do this. The rustc and ruby patches I submitted as an exercise. I went to the issue tracker, sorted by oldest first, and then picked the first issue that had little/no discussion on it. I purposefully avoided picking an issue with significant architectural impact or political context this way. So there's also not much designing and reviewing needed. The merge requests were assigned to very senior reviewers each time. The automated test suites made sure I didn't waste much of anyone's time with trivial errors. Of course the requirement is that you're actually at least proficient with the languages (C for Ruby and Rust for rustc) but beyond that I think anyone can do it with a couple of sunday afternoons spent diligently digging through the codebase.

SauciestGNU 4y ago

Ruby and Rust and Rails aren't exactly hobby projects either. Mission critical software exists that uses those as well. Ultimately it's on the development and deployment teams to pin a version of the runtime for actual consistency in environment.