4 ms·
I wasn't paying much attention to all sorts of safety issues, like potential RCEs, because this was initially intended for local development, not production use
by smoochy 4y ago
I wasn't paying much attention to all sorts of safety issues, like potential RCEs, because this was initially intended for local development, not production use. But do let me know if you see how someone would be able to exploit those scripts without `dock` user knowing about it.
Also, thank you for trying it out and reporting it works even on Windows, pleasantly surprised.
- CoolCold 4y agoI did some monkey patching for exposing ports and it works even further - okay, it automagically logins via ssh now as expected. I can probably send it as is to Github/Gitlab so you have an idea. Disclaimer: was not considering any edge cases with my changes.
- smoochy 4y agoCould you please email me the git patch? Or put it on Github/Gitlab yourself and send me the link. (I think I do make it a bit complex for people to contribute, but I don't have a lot of time to spare).
- CoolCold 4y agoPushed to Github, please take a look - https://github.com/CoolCold/dock/commit/101950b2275b3e920c554c31d5a70d8fa856d952 https://github.com/CoolCold/dock/commit/101950b2275b3e920c55... P.S. Email sounds like it's 1997 and lynx/elinks are still actual ;)
- smoochy 4y agoYeah, ok. I'll be setting up a Github repo soon. I guess that's how we roll these days. Github will be learning more about how to program Bash then.
- CoolCold 4y ago> But do let me know if you see how someone would be able to exploit those scripts My (and my teams) rule of thumb is simple here - if shellcheck complains, that better be reviewed, usually it complains for a reason and makes code better/safer.