4 ms·
> ... his intentions were probably good ... Are we looking at the same pull request? https://github.com/EpicGames/Signup/pull/24/commits/4e531d5c5e60ea600cfb5
by ansible 4y ago
> ... his intentions were probably good ...
Are we looking at the same pull request?
https://github.com/EpicGames/Signup/pull/24/commits/4e531d5c5e60ea600cfb51492367ec11d888f422 https://github.com/EpicGames/Signup/pull/24/commits/4e531d5c...
That's ... a super crap PR, hovering near trollish behavior territory.
- Gigachad 4y agoIt's apparently a young person who submitted it. I think most of us who were that age with github available submitted some crap PRs. I remember I submitted some low quality PRs that just changed comment formatting/typos on some large repos. Not trolling, just trying to contribute in some way and get my name in the project without having enough skills for a real PR.
- bithaze 4y ago> just changed comment formatting/typos I'd call those minor (valid, of course) changes, not low quality changes like what led to this post.