4 ms·

I empathize with that kid - his intentions were probably good but I'm pretty sure he didn't know this would have sent email notifications. Even if he had known,

• charcircuit 4y ago
  >he didn't know this would have sent email notifications Even if it sent push notifications to everyone's browser and phone that doesn't seem much better. When you type an @ it gives you are description of a group and the description makes it clear that it's not the people related to reviewing his PR. He was just trying to send as many notifications as possible to try and get people to look at what he did.
• sidjor 4y ago
  Or may be it was a graded task. Wondering why he was trying to get it merged asap.
• ansible 4y ago
  > ... his intentions were probably good ... Are we looking at the same pull request? https://github.com/EpicGames/Signup/pull/24/commits/4e531d5c5e60ea600cfb51492367ec11d888f422 https://github.com/EpicGames/Signup/pull/24/commits/4e531d5c... That's ... a super crap PR, hovering near trollish behavior territory.
  • Gigachad 4y ago
    It's apparently a young person who submitted it. I think most of us who were that age with github available submitted some crap PRs. I remember I submitted some low quality PRs that just changed comment formatting/typos on some large repos. Not trolling, just trying to contribute in some way and get my name in the project without having enough skills for a real PR.
    • bithaze 4y ago
      > just changed comment formatting/typos I'd call those minor (valid, of course) changes, not low quality changes like what led to this post.