3 ms·
Observations after briefly checking the code: - KISS and YAGNI rules are broken frequently - abuse of inheritance that makes even trivial classes harder to re
by Sankozi 4y ago
Observations after briefly checking the code:
- KISS and YAGNI rules are broken frequently
- abuse of inheritance that makes even trivial classes harder to read
- some usage of boxed types feels incorrect, if null is meaningful it should at least have some comment
- confusing packages (like .ddd.domain vs .domain), would be nice to document what packages mean in readme
- tlandeka 4y ago"domain" is real domain that contains business logic, "ddd" should be extracted to a common library (according to this example https://github.com/VaughnVernon/IDDD_Samples/tree/master/idd https://github.com/VaughnVernon/IDDD_Samples/tree/master/idd... and this one https://github.com/dddshelf/ddd https://github.com/dddshelf/ddd) Regarding to other issues, could you add little bit more concrete details just to check and consider possible solutions.
- beaker52 4y agoDDD isn't about libraries, CQRS, event sourcing, microservices or k8s.
- tlandeka 4y agoI followed the examples from the books. But let's say, my idea is to use that "boilerplate" code on other projects and not broke the DRY principle, I would rather extract that piece of code to be reusable.