5 ms·

LGTM – A simple pull request approval system

37 points by 0des 4y ago

0des 4y ago
"LGTM is a simple pull request approval system using GitHub protected branches and maintainers files or maintainers groups. Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text."
rektide 4y ago
Ok nice but why would gitea org make a github based capability... the road to bootstrapping is long & weird.
- kodah 4y ago
  Gitea's API's are GitHub compatible.
partido3619463 4y ago
“ Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text.” Isn’t this how protected branches and github review functionality works anyways? What does this module add?
- treve 4y ago
  Yes, and it has a number of other features, but it's behind a paywall. So perhaps this is for those that want some of those features but don't want to pay.
  - codsane 4y ago
    The README says it uses GitHub protected branches, so I'm not sure if it does get around the paywall. That would be great though!
- Deukhoofd 4y ago
  Possibly it was not so 6 years ago when the repository was initially made? Of course considering that this is the Gitea fork, their goal might not be the use for Github.
cercatrova 4y ago
I always thought LGTM meant "Let's Get This Money!" and not "Looks Good To Me!" but I suppose either interpretation works in most cases.
- CameronNemo 4y ago
  I thought it was "Let's Get This Merged" and commented it on my own PR once.
  - david_van_loon 4y ago
    It's an ambiguous acronym. I've used it both ways.
    - Thorrez 4y ago
      All the front page Google results appear to say Looks Good To Me https://www.dictionary.com/e/acronyms/lgtm/ https://www.dictionary.com/e/acronyms/lgtm/ https://www.urbandictionary.com/define.php?term=LGTM https://www.urbandictionary.com/define.php?term=LGTM https://www.freecodecamp.org/news/what-do-cryptic-github-comments-mean-9c1912bcc0a4/ https://www.freecodecamp.org/news/what-do-cryptic-github-com... https://knowyourmeme.com/memes/lgtm https://knowyourmeme.com/memes/lgtm https://www.cyberdefinitions.com/definitions/LGTM.html https://www.cyberdefinitions.com/definitions/LGTM.html Urban Dictionary does have Let's Get This Merged as its second definition, but it's at a net of -121 points, whereas Looks Good To Me is at net 941, and was added 10 years earlier. That doesn't seem ambiguous to me.
  - rob74 4y ago
    Well, I assume you wouldn't submit a PR if it didn't look good to you, so the acronym is appropriate...
    - dathinab 4y ago
      you have no idea (1) what some people do when some external force tires to make them contribute to opensource ... 1: ok, you probably do know as most people on HN probably do know

37 points by 0des 4y ago

0des 4y ago

"LGTM is a simple pull request approval system using GitHub protected branches and maintainers files or maintainers groups. Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text."

rektide 4y ago

Ok nice but why would gitea org make a github based capability... the road to bootstrapping is long & weird.

kodah 4y ago
Gitea's API's are GitHub compatible.

partido3619463 4y ago

“ Pull requests are locked and cannot be merged until the minimum number of approvals are received. Project maintainers can indicate their approval by commenting on the pull request and including LGTM (looks good to me) in their approval text.” Isn’t this how protected branches and github review functionality works anyways? What does this module add?

treve 4y ago
Yes, and it has a number of other features, but it's behind a paywall. So perhaps this is for those that want some of those features but don't want to pay.
- codsane 4y ago
  The README says it uses GitHub protected branches, so I'm not sure if it does get around the paywall. That would be great though!
Deukhoofd 4y ago
Possibly it was not so 6 years ago when the repository was initially made? Of course considering that this is the Gitea fork, their goal might not be the use for Github.

cercatrova 4y ago

I always thought LGTM meant "Let's Get This Money!" and not "Looks Good To Me!" but I suppose either interpretation works in most cases.

CameronNemo 4y ago
I thought it was "Let's Get This Merged" and commented it on my own PR once.
- david_van_loon 4y ago
  It's an ambiguous acronym. I've used it both ways.
  - Thorrez 4y ago
    All the front page Google results appear to say Looks Good To Me https://www.dictionary.com/e/acronyms/lgtm/ https://www.dictionary.com/e/acronyms/lgtm/ https://www.urbandictionary.com/define.php?term=LGTM https://www.urbandictionary.com/define.php?term=LGTM https://www.freecodecamp.org/news/what-do-cryptic-github-comments-mean-9c1912bcc0a4/ https://www.freecodecamp.org/news/what-do-cryptic-github-com... https://knowyourmeme.com/memes/lgtm https://knowyourmeme.com/memes/lgtm https://www.cyberdefinitions.com/definitions/LGTM.html https://www.cyberdefinitions.com/definitions/LGTM.html Urban Dictionary does have Let's Get This Merged as its second definition, but it's at a net of -121 points, whereas Looks Good To Me is at net 941, and was added 10 years earlier. That doesn't seem ambiguous to me.
- rob74 4y ago
  Well, I assume you wouldn't submit a PR if it didn't look good to you, so the acronym is appropriate...
  - dathinab 4y ago
    you have no idea (1) what some people do when some external force tires to make them contribute to opensource ... 1: ok, you probably do know as most people on HN probably do know