4 ms·
I think I like this better expressed as a linter than a code reviewer. Maybe it doesn't sell as well. But giving this to devs to help them make better PRs and h
by mchusma 4y ago
I think I like this better expressed as a linter than a code reviewer. Maybe it doesn't sell as well. But giving this to devs to help them make better PRs and have more confidence in approval? Good. Skipping code review? Bad.
In my experience, most "issues" in code review are not technical errors, they are business logic errors, which there is most of the time not even enough context in the code to know what the right answer is. It is in a PM or Sales Person's head.
- onionisafruit 4y agoYour comment changed my mind about this. I still don’t want it to do reviews for me, but now I do want it to pre-review my changes before I create a PR so that I can avoid unnecessary review cycles from obvious mistakes.
- fourneau 4y agoAgreed. As it is, it's a great pre-step. Skipping code review is depriving the team of an opportunity to learn about the new incoming change, and depriving them of sharing knowledge (better implementations, business context, etc.)
- michaelbarton 4y agoWould be great to do something similar for journal reviews too!