3 ms·
is this just (not) approving or is it actually providing automated feedback for what needs to be fixed and suggestions?
by sabujp 4y ago
is this just (not) approving or is it actually providing automated feedback for what needs to be fixed and suggestions?
- videlov 4y agoIt is like a first-line reviewer. It approves contributions that it is really confident are good and leaves the rest to humans. So basically it saves time and content switching for developers.
- mikeryan 4y agoIs there no marker that can be provided to indicate why it failed or even a line number? Can't tell if it's something like formatting and code style or "bad code" or what. Even as a first line reviewer I can't tell if this is valuable or not without any details on why it would approve something. The PR's it would Approve here were all super minor. Could probably get similar number of these approved just by doing a Lines of Code changed + "Has it been linted" It's really hard to tell if this is valuable or not yet.
- videlov 4y agoYou are making a very good point. Right now it can't give such indication because it is a black-box model. There are hundreds of inputs that go in (eg. characteristics of the code, how much the author has worked with this code in the past, how frequently this part of the code changes) and the output is how confident the model is that the contribution is safe to merge. With that said, there are ways of exposing more details to developers. For example, scoring is done per-file, and Codeball can tell you which files it was not confident in.