4 ms·
Wow, it is surprising how awful every last bit of Zircon code reproduced here is. I have to guess the rest is about as bad. This dreck would never pass code re
by ncmncm 4y ago
Wow, it is surprising how awful every last bit of Zircon code reproduced here is. I have to guess the rest is about as bad.
This dreck would never pass code review at my shop.
- ncmncm 4y agoDownvote all you like, it is bad code all the same.
- PaulDavisThe1st 4y agoIf you said why, you'd be less likely to get downvoted. Hand-waving assertions of "that dreck" are not well judged.
- ncmncm 4y agoAnybody who can look at the reproduced code and not recoil in disgust will be unlikely to understand a detailed criticism. Just read it!
- skavi 4y agoI'd encourage you to have a go at explaining nonetheless. I'm sure there are at least a few critiques you have which many here would miss, even if they are competent. There's always value in code review, no?
- Teckla 4y agoSpeaking just for myself, after perusing Fuchsia source, the code seems eye-wateringly "clever," pretty much everywhere. I'm doubtful many people would be able to read it or contribute to it very effectively.
- Jyaif 4y agoI skimmed through the article and nothing stood out. Can you give an example of a piece of code you didn't like?
- ncmncm 4y agoEvery last bit of Zircon code he reproduced in the article was a woolly mess that the code's author (not the article's) should be ashamed of. That the author found it easy to code an exploit for a system he knew so little about shows that the code is not just woolly, but actually bad.
- goodpoint 4y agoHN downvotes things based on the mood expressed rather than the technical content. It's becoming a kindergarten, really.
- SOLAR_FIELDS 4y agoI didn’t downvote but I think it’s more because grandparent reads like a shallow offhand dismissal. Perhaps if GP provided examples of bad code and better ways to express them it would be a more productive comment.
- shkkmo 4y agoI didn't see any actual technical content in that comment. I don't see any repliers commenting on tone but I do see a comment or remarking that they disagree with the technical assertion and asking for actual technical content to back it up. So I think your assumptions about the reasons for the down votes are inaccurate.