4 ms·

What other antipatterns are there? I can understand the criticism of having configuration code with business logic, and think there should be better commenting/

• gjulianm 4y ago
  Type hints in that code are erasing the actual signature of the function, so you won't get type checks on the arguments. For @redirect, you'd be better served by using the logging module. Higher order functions are ok, but the problem with this what they're using it for. Code that behaves different based on environment without any explicit warning for the caller? That's fairly dangerous.
  • mrtranscendence 4y ago
    > Type hints in that code are erasing the actual signature of the function True enough. For the reader of these comments, it's possible (but non-obvious) to properly respect type hints in a decorator. See here: https://mypy.readthedocs.io/en/stable/generics.html#declaring-decorators https://mypy.readthedocs.io/en/stable/generics.html#declarin...