4 ms·
I'm becoming convinced that using the phrase "code smell" might as well be a "smell" itself. Maybe it's just me, but I've only heard the phrase used as a rhetor
by jamesgreenleaf 4y ago
I'm becoming convinced that using the phrase "code smell" might as well be a "smell" itself. Maybe it's just me, but I've only heard the phrase used as a rhetorical mask for a developer to express some individual preference as though it were an objective fact.
- HPsquared 4y agoMore taste than smell, then.
- jamesgreenleaf 4y agoNow you're making sense.
- sn41 4y agoI see you haven't lost your touch.
- pylua 4y agoA lot of IDE plugins will tag code smell as things that may potentially be a bug in your code. I like that more objective use of the term.
- mostlylurks 4y agoThose preferences come from experience. If experience tells you that code written in a certain manner consistently causes certain categories of issues later down the road, it's perfectly justified to be wary of such code.
- robonerd 4y agoWhen somebody tells you about code smell, ask them to describe the smell. If they can describe it, then you can weigh the merit of their arguments. If 'describe the smell' stumps them, brush their remark aside until they can come back with something more substantial.
- Brian_K_White 4y agoCan you describe describing the smell of a code smell? Are you saying that sometimes people say "x is a code smell" without saying what the issue is?
- robonerd 4y ago> Are you saying that sometimes people say "x is a code smell" without saying what the issue is? Oh yeah... CRs with lines marked simply "code smell", not even an "x is a".
- Brian_K_White 4y agoHah, wow. I'd have some fun with that. "Is it blueberry?"
- jamesgreenleaf 4y agoGood idea. But now I'm imagining devs as sommeliers, picking out floral notes and hints of oak.