3 ms·
This is actually a requirement on my team. If someone does not do a self review, I leave a comment explaining that I won't be reviewing the work until the decis
by vinnymac 4y ago
This is actually a requirement on my team. If someone does not do a self review, I leave a comment explaining that I won't be reviewing the work until the decisions that were made are explained.
This helps understand the justifications for the change, and prevents unnecessary feedback loops to an incredibly high degree.
- b3morales 4y agoIn my opinion this is the purpose of a commit message. Header: short description of the change; body: details, including justification for the change. But I agree, it's also good when people preemptively make comments on their own commits in the code review interface. Question for you though: do you have a size limit on this requirement? I.e., changes that are small enough don't need to do this?