4 ms·

Why your team doesn't need to use pull requests

• eternityforest 4y ago
  It seems like the question of which is better would be mostly determined by whether you have lots of merge conflicts or not. If your project details are such that you don't get many, then I'm not sure I would want to give up the benefits of PRs. PRs make sure that someone else has seen your code. They discourage you from writing anything the whole rest of the team can't immediately understand. Having mostly worked on teams with no formal process at all, people at times seem to not even glance at any code besides what they wrote themselves if they don't have to. I think they might even work better on a real dedicated team than a foss project, because foss projects suffer from pull requests going stale for 8 months with zero interest or attention, long enough to where they can no longer be merged without more work than totally recreating them. When you have 1 person who approves PRs and 15 who make them... stuff is going to get stale.