4 ms·
Have you measured this in your organisation? In my experience, every team has a fairly distinct cut-off point where if you make PRs larger than that, they start
by kqr 5y ago
Have you measured this in your organisation? In my experience, every team has a fairly distinct cut-off point where if you make PRs larger than that, they start to hang around in someone's review queue forever.
Every time I've made a larger PR I've regretted it and subsequently split it up into smaller ones. I get higher quality feedback and faster feedback to boot that way.
- dkersten 5y ago> if you make PRs larger than that, they start to hang around in someone's review queue forever. Or you just get a "ship it" without more than a cursory glance.