3 ms·
Many many decades ago, non-optimising compilers would literally check 1==1 on each iteration of the latter. Not a problem now.
by chrisseaton 4y ago
Many many decades ago, non-optimising compilers would literally check 1==1 on each iteration of the latter.
Not a problem now.
- rowanG077 4y agoAnd why would you need to write while(1==1) and not just while(1)?
- chrisseaton 4y agoYou don’t - but the compiler needs to test if 1 is true (so conceptually 1==1) every iteration if it isn’t an optimising compiler. They lack the code to remove a tautological test. But approximately all compilers these days are optimising compilers, so don’t worry about it.
- rowanG077 4y agoYes that I was questioning the, to me, non-sensical 1==1. Why would you not for the normal form of the tautological statement, And if you don't go for the normal form, why choose 1==1 and not one of the infinite other forms.
- chrisseaton 4y ago> Why would you not for the normal form of the tautological statement Because normalising is an optimization, and these compilers didn't have any optimisations. That was normal back then. You had a whole separate product that was specifically an 'optimising compiler'. These days that's implicit and we just say 'compiler'. These days, even -O0 will canonicalise the condition! That's how normalised it is! But I guess this is done during translation to IR, rather than as an 'optimisation'. https://godbolt.org/z/Eoqs7hxqs https://godbolt.org/z/Eoqs7hxqs
- rowanG077 4y agoThe question is not a question of optimization but readability. Can you honestly say you would let `while (1 + 3 * 5 < 10 + 8 - 5 * 1000)` stand in a code review for a simple infinite loop because "the compiler will optimize it anyway".
- chrisseaton 4y agoYou’re confused - nobody is suggesting writing anything but ‘while (1)’ at the source code level. We’re talking about how the compiler implements that, and how internally it needs to do ‘1 == 1’ for each iteration if it doesn’t optimise at all. We’re talking compiler implementation and optimisation - not coding aesthetics.
- rowanG077 4y agoThat makes little sense. There is no equality check in the generated ASM. A compuler doesn't synthesize 1==1 when a `while(1)` is used. Your link even shows this. There is no `cmp` opcode used. A simple unconditional `jmp` is used.
- chrisseaton 4y agoAre you trolling me? > Your link even shows this. Yes the link shows how it doesn't matter today! Because almost all compilers are now 'optimising compilers'! > There is no `cmp` opcode used. A simple unconditional `jmp` is used. Oh my god that's the entire point! That's how compilers work now. They always optimise. They didn't used to do that. The compiler checks the truthiness of the value in the while condition. Modern compilers remove it with either a tautology check, or a shortcut during IR building. They didn't used to do that, so there used to be a cost, which is why people started cargo-culting the for equivalent. Here's a worked example using a niche compiler with a very different architecture that unusually still doesn't canonicalise during building. Compare https://godbolt.org/z/3v3anacM8 https://godbolt.org/z/3v3anacM8 and https://godbolt.org/z/chWjsen4s https://godbolt.org/z/chWjsen4s See the difference? See the 'cmp eax, 1' and then how it goes away under optimisation?
- Taniwha 4y agoreally "while (1)" is the same as "while (1 != 0)" but it's not really any difference, and as mentioned 1==1 and 1!=0 will be optimised out to the same thing