3 ms·
> Can you use `unsafe` to mark off entire scopes to avoid having to redeclare it? Yes. > Cargo having to phone home all the time sounds annoying, though. It
by steveklabnik 5y ago
> Can you use `unsafe` to mark off entire scopes to avoid having to redeclare it?
Yes.
> Cargo having to phone home all the time sounds annoying, though.
It does not have to phone home, ever. They for some reason didn't seem to want to use the right workflow, but that workflow does exist, and is an important and well-supported use-case.
(It seems from the bug report that they did hit a confusing error message, which is unfortunate.)
- faitswulff 5y agoThanks for the clarifications!
- steveklabnik 5y agoNo problem. And I am serious about the "for some reason" bit, I don't know why `cargo vendor` isn't acceptable for them, but they know their requirements better than I do.
- tptacek 5y agoShe gave the reason in the piece, and linked to the ticket she filed: https://github.com/rust-lang/cargo/issues/10352 https://github.com/rust-lang/cargo/issues/10352
- steveklabnik 5y agoI read the piece and the ticket. I still don’t understand. That’s fine, it’s not my responsibility to anymore. I’m glad they found a solution they’re happy with. Specifically, cargo vendor was suggested in the ticket, but there was no response as to why it wasn’t adequate for this case, just that it doesn’t “feel” good. I’m probably missing something.
- tptacek 5y agoThe reason is right there in the ticket. They have exactly one dependency, and it's optional. They don't want to vendor it just so they can build the no-capstone artifact in CI without having to phone home to crates.io or whatever. You don't have to agree with her, but you can't pretend she didn't give a clear reason.
- steveklabnik 5y agoSaying “we don’t want to” is technically a reason, sure, but it doesn’t mean I understand the why. Why is that a problem? (Depending on that why, I have an idea or two for a workaround, but you can’t suggest solutions until you understand the actual issue. I have my own laundry list of issues with Cargo that I have to work around; it’s painful and I have a lot of empathy for that.)
- tptacek 5y agoFor all the same reasons that vendoring isn't the default option in any dependency management system in any language: because there is a cost to vendoring. She didn't say that, but I wouldn't think she'd have to. You don't vendor all of your dependencies either: why not? There's your answer. I'm wondering if maybe you've missed the part where they don't need this single dependency in the builds they're talking about doing. It seems like the Rust community people responding on the ticket had no trouble understanding what the issue is. There's a difference between acknowledging something and conceding that it needs to be changed.
- steveklabnik 5y agoI don’t because I don’t need to worry about offline builds. If I did, then I’d vendor them. Hence not understanding. (And even if it literally is that only, then I have at least one idea for what they could do that would make this work. But maybe that solution would fail for other reasons, and I want to acknowledge that it’s not like I have the full requirements list and am saying “oh gosh just do this,” because I am not.) That it’s a single dependency is why it feels extreme to me; won’t that be a very, very tiny thing to vendor? Anyway I don’t really know why you’re being so aggro here. I don’t know how many times I can say “I’m probably missing something” and “they know better than I do.” I really like you, Thomas, but I also hear the passive aggression, and don’t like it. It makes me want to return it, but that doesn’t benefit anyone.
- tptacek 5y agoYou said "They for some reason didn't seem to want to use the right workflow", which by my lights manages to be both loaded and dismissive (if that was the goal, well played). I pointed out that the "some reason" is right there in the post, and you doubled down. I'm not sure why you did; you could have just said, "oh, interesting, thanks" and I'd have said "pip pip! cheerio!" but if you want instead to... uh... explore the contours of this controversy? I'm always game, which is what you're experiencing now. If you want to keep me invested in a programming discussion, one very good way to do it is to imply that you can't for the life of you understand why someone wouldn't want to vendor Capstone.