5 ms·

ok, what do those do?

foolfoolz 4y ago
tell microsoft when you’re using features. presumably because they have a culture of metrics and every feature is required to have data on its usage patterns
- nojito 4y ago
  It's just used to drive improvement efforts rather than focusing on features + bugs no one cares about/uses.
rolph 4y ago
i read the code , they take usage data points build a logfile and wait for a request to retrive.
Lammy 4y ago
There are some pretty detailed comments on many of them if you click through to their call sites, and more can be inferred from the file names of the callers. Let's take a look at `windowio.cpp` for example. This most-generic event fires every time you type any input character on the keyboard: https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowio.cpp#L165-L173 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... It also has more-specific events for several different ways of selecting, copying, and pasting text: https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowio.cpp#L230-L329 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... In `find.cpp` we can see it log every time you find the next result in the "Find" dialog, as well as when the dialog is closed: https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/find.cpp#L64-L82 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... In `windowproc.cpp` we can see it log every time you resize a console window, close a console window, bring up the context (right-click) menu, drag-and-drop on to a console window: - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowproc.cpp#L164-L174 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowproc.cpp#L323-L332 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowproc.cpp#L474 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowproc.cpp#L868-L872 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... This even extends outside the "Terminal" application wrapper itself, with a generic "LogApiCall" used to track e.g. any time any other process spawns a console window: - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/host/srvinit.cpp#L797-L798 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/host/telemetry.hpp#L56-L124 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... Click around a few of the search results and see what else you can find!
- mftb 4y ago
  Thanks for doing this. Looking over some of the actual call sites and there commentary was interesting. For all the folks who say it's all totally innocuous (or even beneficial). Even if it is, I can tell you, I have no interest in my computer doing this while I'm using it.
  - donmcronald 4y ago
    I've always wondered what the performance impact is. Windows 10 feels so slow compared to Windows 7 and earlier that I'm constantly wondering how much of my life is being allocated to telemetry.
    - mftb 4y ago
      Not sure but it's a reasonable question. I'm willing to give MS the benefit of the doubt and guess that they have generally implemented it in as light a way as possible, but that said sometimes it probably causes dire performance problems to outright breakage. For me it's largely academic at this point, but it's another reason to be happy I moved my main workstation off Windows.
      - sirsinsalot 4y ago
        You're willing to give MS the benefit of the doubt? I remember the bad old days and they no longer have this luxury from me.
        mftb 4y ago
        Understood and when I was being forced to deal with it more often, I was not feeling so magnanimous either.
    - jiggawatts 4y ago
      The impact is absolutely noticeable, just difficult to attribute. Every time I rebuild my laptop it has these “mysterious” slowdown periods that force me to dig through the metrics to see what is the culprit. About 80% of the time it’s telemetry. The worst one is actually the Intel driver installer which has telemetry that is so far beyond obnoxious that it’s an embarrassment to every so-called “engineer” involved. Shame. Shame.

tell microsoft when you’re using features. presumably because they have a culture of metrics and every feature is required to have data on its usage patterns

nojito 4y ago
It's just used to drive improvement efforts rather than focusing on features + bugs no one cares about/uses.

rolph 4y ago

i read the code , they take usage data points build a logfile and wait for a request to retrive.

Lammy 4y ago

There are some pretty detailed comments on many of them if you click through to their call sites, and more can be inferred from the file names of the callers. Let's take a look at `windowio.cpp` for example. This most-generic event fires every time you type any input character on the keyboard: https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowio.cpp#L165-L173 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... It also has more-specific events for several different ways of selecting, copying, and pasting text: https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowio.cpp#L230-L329 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... In `find.cpp` we can see it log every time you find the next result in the "Find" dialog, as well as when the dialog is closed: https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/find.cpp#L64-L82 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... In `windowproc.cpp` we can see it log every time you resize a console window, close a console window, bring up the context (right-click) menu, drag-and-drop on to a console window: - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowproc.cpp#L164-L174 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowproc.cpp#L323-L332 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowproc.cpp#L474 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/interactivity/win32/windowproc.cpp#L868-L872 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... This even extends outside the "Terminal" application wrapper itself, with a generic "LogApiCall" used to track e.g. any time any other process spawns a console window: - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/host/srvinit.cpp#L797-L798 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... - https://github.com/microsoft/terminal/blob/57c3953aca49f68acc480ca27533fdc7aad78b43/src/host/telemetry.hpp#L56-L124 https://github.com/microsoft/terminal/blob/57c3953aca49f68ac... Click around a few of the search results and see what else you can find!

mftb 4y ago
Thanks for doing this. Looking over some of the actual call sites and there commentary was interesting. For all the folks who say it's all totally innocuous (or even beneficial). Even if it is, I can tell you, I have no interest in my computer doing this while I'm using it.
- donmcronald 4y ago
  I've always wondered what the performance impact is. Windows 10 feels so slow compared to Windows 7 and earlier that I'm constantly wondering how much of my life is being allocated to telemetry.
  - mftb 4y ago
    Not sure but it's a reasonable question. I'm willing to give MS the benefit of the doubt and guess that they have generally implemented it in as light a way as possible, but that said sometimes it probably causes dire performance problems to outright breakage. For me it's largely academic at this point, but it's another reason to be happy I moved my main workstation off Windows.
    - sirsinsalot 4y ago
      You're willing to give MS the benefit of the doubt? I remember the bad old days and they no longer have this luxury from me.
      - mftb 4y ago
        Understood and when I was being forced to deal with it more often, I was not feeling so magnanimous either.
  - jiggawatts 4y ago
    The impact is absolutely noticeable, just difficult to attribute. Every time I rebuild my laptop it has these “mysterious” slowdown periods that force me to dig through the metrics to see what is the culprit. About 80% of the time it’s telemetry. The worst one is actually the Intel driver installer which has telemetry that is so far beyond obnoxious that it’s an embarrassment to every so-called “engineer” involved. Shame. Shame.