7 ms·
I'm assuming he thought his PR would be rejected, given their reaction to his initial questions about the issue: https://github.com/microsoft/terminal/issues/1
by HideousKojima 5y ago
I'm assuming he thought his PR would be rejected, given their reaction to his initial questions about the issue:
https://github.com/microsoft/terminal/issues/10362 https://github.com/microsoft/terminal/issues/10362
- zamalek 5y agoA closed PR would have been even more damning for Microsoft. Especially given that Casey could have provided apples-apples benchmark results - not, what amounts to, a micro-benchmark. From my perspective, there are two reasons why someone would build an entire project instead of opening a PR: * Merely to be able to point and it and say, "see? see? I was right!" How obnoxiously childish. * Implementing his ideas into a mature/non-greenfields codebase wasn't in-fact "extremely simple."
- db48x 5y agoHe simply didn't want to license his modifications under the terms required by Microsoft.