4 ms·
Really? Is there any science showing rude reviews improve some metric or some greater good?
by cscurmudgeon 5y ago
Really?
Is there any science showing rude reviews improve some metric or some greater good?
- KMag 5y agoIt wasn't the best way to criticize the code review. If I could go back in time 15 years, it's also not the first mistake I would fix. It stuck in my mind because I felt bad about it. I was frustrated that I had been hounded to drop what I was doing and fix the build because of clear style guide violations that a reviewer let slip. (A couple years later, Google implemented every commit getting a full compilation and run of all tests that code-coverage showed affected the covered code. These days, I wouldn't have been hounded to fix a build break caused by someone else.)