4 ms·
> So far as hash collisions are concerned, these are very unlikely in this use-case. This is not a hash map where hash flooding is a concern, and accidental col
by lifthrasiir 5y ago
> So far as hash collisions are concerned, these are very unlikely in this use-case. This is not a hash map where hash flooding is a concern, and accidental collisions are so unlikely as to be a negligible risk.
The current compiler will silently ignore colliding hashes and (I believe) result in a very confusing error. The probability of this happening is not very large, but still not small enough that someone will hit this error probably this year. At the very least you need to report hash collisions so that you can somehow rename your modules and so on.
- ddevault 5y agoChecking the bucket entries based on their module identifier instead of (or in addition to) their key is a simple and obvious improvement to this code. https://todo.sr.ht/~sircmpwn/hare/679 https://todo.sr.ht/~sircmpwn/hare/679