3 ms·
The first person who ever submitted a PR to one of my projects also reformatted the files he touched according to whatever formatter his IDE was using, which wa
by ALittleLight 5y ago
The first person who ever submitted a PR to one of my projects also reformatted the files he touched according to whatever formatter his IDE was using, which was different than mine. I was conflicted about whether to accept his change and inferior formatting or whether telling him to adopt my formatting would be obnoxious. I settled on merging his change and then instantly reformatting it to the way I like it - keeping the meaningful part of his change.
- newaccount74 5y agoReformatting changes are the worst -- they break the git history, and in a few years when you try to find the commit message for a specific line of code you'll have to navigate past the formatting changes...