4 ms·
Here's a relevant quote from Google's code review guidelines on speed https://google.github.io/eng-practices/review/reviewer/speed.html https://google.github.io
by beebmam 4y ago
Here's a relevant quote from Google's code review guidelines on speed https://google.github.io/eng-practices/review/reviewer/speed.html https://google.github.io/eng-practices/review/reviewer/speed...
>When code reviews are slow, several things happen: ...
>Developers start to protest the code review process. If a reviewer only responds every few days, but requests major changes to the CL each time, that can be frustrating and difficult for developers. Often, this is expressed as complaints about how “strict” the reviewer is being. If the reviewer requests the same substantial changes (changes which really do improve code health), but responds quickly every time the developer makes an update, the complaints tend to disappear. Most complaints about the code review process are actually resolved by making the process faster.
- mhitza 4y agoThat guideline definitely must applies only internally. All the Google public repos I've interacted with stall in the PR department like crazy.