2 ms·
Give all your feedback at once. Sometimes that just really isn't feasible or efficient. Happens often enough I glance over a PR to see it has code style issues
by stinos 4y ago
Give all your feedback at once.
Sometimes that just really isn't feasible or efficient. Happens often enough I glance over a PR to see it has code style issues or obvious mistakes in the code or architectural problems. Especially in those last cases, when the implementation still needs to change, I'll just point that out, then later on revisit and do a more thorough review. Because it makes no sense reviewing things which might not even end up in the final PR.
- phyzix5761 4y agoHence why I said "and the(n) getting more comments (on something unrelated) by the same person". I understand clarifying comments after changes have been made but comments in a completely separate part of the code that have nothing to do with the original feedback keeps the PR open forever.